Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a confirmation mechanism to notify users when the Fleet agent successfully installed on Windows. #24987

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Added a confirmation mechanism to notify users when the Fleet agent successfully installed on Windows. #24987

wants to merge 2 commits into from
+27 −4

Conversation

parsimeikoikai
Copy link
Contributor

@parsimeikoikai parsimeikoikai commented Dec 23, 2024 •
edited
Loading

Fix fo #21980

Checklist for submitter

  • For Orbit and Fleet Desktop changes:
    • Orbit runs on macOS, Linux and Windows. Check if the orbit feature/bugfix should only apply to one platform (runtime.GOOS).
    • Manual QA must be performed in the three main OSs, macOS, Windows and Linux.

@parsimeikoikai
Added a confirmation mechanism to notify users when the Fleet agent i…
aec043a 
…s successfully installed on Windows.

This improves user feedback and aligns with behavior on macOS.
@codecov Codecov
Copy link

codecov bot commented Dec 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.82%. Comparing base (9181ba7) to head (aa537a1).
Report is 70 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #24987      +/-   ##
==========================================
- Coverage   63.83%   63.82%   -0.01%     
==========================================
  Files        1615     1615              
  Lines      153608   153608              
  Branches     4039     3986      -53     
==========================================
- Hits        98059    98044      -15     
- Misses      47748    47759      +11     
- Partials     7801     7805       +4
Flag Coverage Δ
backend 64.69% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@parsimeikoikai parsimeikoikai marked this pull request as ready for review January 4, 2025 05:11
@parsimeikoikai parsimeikoikai requested a review from a team as a code owner January 4, 2025 05:11
@lukeheath
Copy link
Member

@parsimeikoikai Thanks for your PR! We're a little delayed with the recent holidays but we'll make sure this gets looked at soon.

@lukeheath lukeheath requested a review from noahtalerman January 6, 2025 16:31
@lukeheath lukeheath added the :product Product Design department (shows up on 🦢 Drafting board) label Jan 6, 2025
@lukeheath lukeheath marked this pull request as draft January 6, 2025 16:31
@lukeheath
Copy link
Member

I'm converting this PR to a draft while I run #21980 through our product design process to review the product change. (cc @noahtalerman)

@noahtalerman
Copy link
Member

Hey @parsimeikoikai very cool stuff!

Can you please share a video recording that demos the notification you added? This will help us understand your proposed UX.

Thanks!

@noahtalerman noahtalerman mentioned this pull request Jan 9, 2025
Open
@noahtalerman noahtalerman added :product Product Design department (shows up on 🦢 Drafting board) and removed :product Product Design department (shows up on 🦢 Drafting board) labels Jan 9, 2025
@noahtalerman
Copy link
Member

@parsimeikoikai can you please share a video recording that demos the notification you added? This will help us understand your proposed UX.

Thanks!

@noahtalerman noahtalerman mentioned this pull request Feb 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahtalerman noahtalerman Awaiting requested review from noahtalerman

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parsimeikoikai @lukeheath @noahtalerman